Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Slot-manager with additional informations and a method #1217

Merged
merged 5 commits into from
Jan 4, 2023

Conversation

Apollon77
Copy link
Contributor

Pull Request Template

PR Checklist

  • I have run npm test locally and all tests are passing.
  • I have added/updated tests for any new behavior.
  • If this is a significant change, an issue has already been created where the problem / solution was discussed: [N/A, or add link to issue here]

PR Description

This PR mainly provides additional information on slot filling:

  • a new property in result.slotFill states which slot/entity was filled in the current/latest run
  • a new property in the entities called isSlotFillingFallback flags an entity by filled by the defined fallback logic (when trying to fill a specific slow but the given answer do not match to a property then tze full answer is filled, but in fact it is a "special" way to fill the slot. So a developer can not check and handle this

Additionally the slot-manager geta a new method to get the info if a intenthas entities defined.

@Apollon77
Copy link
Contributor Author

@eric-lara Ready for review

PS: I think that the microsoft builtin test is the reason for the issues together with a memomry isue in nodejs 16 I heared of ... that test is very huge and can lead to mem isues

@ericzon
Copy link
Collaborator

ericzon commented Nov 30, 2022

I saw the issue you heard about v16 (jestjs/jest#11956). Running only that job should pass, but it's annoying.

@Apollon77 Apollon77 requested a review from ericzon December 5, 2022 08:51
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Apollon77
Copy link
Contributor Author

@ericzon All PRs ready for review

@ericzon ericzon merged commit 538c823 into axa-group:master Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants