fix(ner): deserialize regex from JSON #1314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a bug with Named Entity Recognition where it doesn't deserialize regular expressions from JSON properly for all rule types.
AndersDJohnson
changed the title
|
Kudos, SonarCloud Quality Gate passed!
|
This was referenced May 19, 2023
|
LGTM ... but i have no real powers in this repo ... @ericzon @ericaltran |
ericzon
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
PR Checklist
npm testlocally and all tests are passing.Some ESLint warnings, but same amount as in
master:All tests pass:
PR Description
Fixes a bug with Named Entity Recognition where it doesn't deserialize regular expressions from JSON properly for all rule types.
A possible alternative to the fixes in #1292 and #1278 (though I'm not 100% sure if it covers those use cases).