-
Notifications
You must be signed in to change notification settings - Fork 135
Use the correct rule for k8s_service in hellogrpc service. #144
Conversation
Thanks for this fix! Let me figure out how to get these status contexts passing and then will merge. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bweston92, fejta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test pull-rules-k8s-e2e |
/ok-to-test |
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
/override cla/google |
@fejta: Overrode contexts on behalf of fejta: cla/google In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test pull-rules-k8s-e2e |
/override cla/google |
@nlopezgi: Overrode contexts on behalf of nlopezgi: cla/google In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
(this may be wrong but I can't see k8s_service being used anywhere and a service isn't a deployment)