Skip to content
This repository was archived by the owner on Feb 6, 2024. It is now read-only.

Use the correct rule for k8s_service in hellogrpc service. #144

Merged
merged 4 commits into from
Jul 24, 2018
Merged

Use the correct rule for k8s_service in hellogrpc service. #144

merged 4 commits into from
Jul 24, 2018

Conversation

bweston92
Copy link
Contributor

(this may be wrong but I can't see k8s_service being used anywhere and a service isn't a deployment)

@fejta
Copy link
Contributor

fejta commented Jun 27, 2018

Thanks for this fix! Let me figure out how to get these status contexts passing and then will merge.
/assign

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bweston92, fejta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nlopezgi
Copy link
Contributor

/test pull-rules-k8s-e2e

@erain
Copy link
Contributor

erain commented Jul 23, 2018

/ok-to-test

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@fejta
Copy link
Contributor

fejta commented Jul 23, 2018

/override cla/google

@k8s-ci-robot
Copy link

@fejta: Overrode contexts on behalf of fejta: cla/google

In response to this:

/override cla/google

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nlopezgi
Copy link
Contributor

/test pull-rules-k8s-e2e

@nlopezgi
Copy link
Contributor

/override cla/google
(see above)

@k8s-ci-robot
Copy link

@nlopezgi: Overrode contexts on behalf of nlopezgi: cla/google

In response to this:

/override cla/google
(see above)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nlopezgi nlopezgi merged commit 3d18d96 into bazelbuild:master Jul 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants