Skip to content
This repository was archived by the owner on Feb 6, 2024. It is now read-only.

Update rules_docker to latest. #150

Merged
merged 2 commits into from
Jun 27, 2018
Merged

Update rules_docker to latest. #150

merged 2 commits into from
Jun 27, 2018

Conversation

xingao267
Copy link
Member

@xingao267 xingao267 commented Jun 27, 2018

Fixes #125

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:

Assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

nlopezgi
nlopezgi previously approved these changes Jun 27, 2018
@nlopezgi
Copy link
Contributor

Can you update nodejs repo to:
http_archive(
name = "build_bazel_rules_nodejs",
sha256 = "6139762b62b37c1fd171d7f22aa39566cb7dc2916f0f801d505a9aaf118c117f",
strip_prefix = "rules_nodejs-0.9.1",
urls = ["https://github.com/bazelbuild/rules_nodejs/archive/0.9.1.zip"],
)

@nlopezgi nlopezgi dismissed their stale review June 27, 2018 15:12

approved by mistake

@xingao267
Copy link
Member Author

Done.

@erain
Copy link
Contributor

erain commented Jun 27, 2018

We can merge this PR if all tests passes, except the examples/hellogrpc/py failed in Travis. (This is because the root cause of the failure is with py_image and has nothing to do with the PRs, see #143 replies)

@nlopezgi nlopezgi merged commit e554f0c into bazelbuild:master Jun 27, 2018
@xingao267 xingao267 deleted the fix branch June 27, 2018 15:27
@erain
Copy link
Contributor

erain commented Jun 27, 2018

I fixed the secret of Travis CI, so at least now Travis will actually run and failed "the right way".

@fejta
Copy link
Contributor

fejta commented Jun 27, 2018

This also seems to fix #149 (bazel <build|test> //... works again)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants