Skip to content
This repository was archived by the owner on Feb 6, 2024. It is now read-only.

switch from native.git_repository to external git_repository #157

Merged
merged 3 commits into from
Jul 18, 2018

Conversation

excavador
Copy link
Contributor

switch from native.git_repository to external git_repository from '@bazel_tools//tools/build_defs/repo:git.bzl' (#140)

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@excavador excavador force-pushed the external-git-repository branch from ef5a51e to 3b37cec Compare July 6, 2018 10:15
@googlebot
Copy link

CLAs look good, thanks!

Copy link
Contributor

@erain erain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

For now this is good but eventually we may want to switch all git_repository to http_archive since it is recommended.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: erain, excavador

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@excavador
Copy link
Contributor Author

So, can we merge this PR?

@erain
Copy link
Contributor

erain commented Jul 9, 2018

/ok-to-test

@nlopezgi nlopezgi merged commit ae6b346 into bazelbuild:master Jul 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants