-
Notifications
You must be signed in to change notification settings - Fork 135
Propagate arguments for implicit attributes to instantiated rules #204
Conversation
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
@ash2k Could you approve the cla please? |
@Globegitter Something's not right with the bot - see #143 (comment) |
Thanks for putting this together @Globegitter |
@nlopezgi I confirm the CLA. Is that ok? |
/ok-to-test |
@Globegitter yes, that is OK, thanks! |
/retest |
@Globegitter actually, just noticed we also need a confirmation from @ash2k here too if possible that they accept the CLA. |
/retest |
New changes are detected. LGTM label has been removed. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Globegitter, nlopezgi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
thanks @Globegitter this PR is ready to be squashed, all I need is confirmation from @ash2k for the CLA and then I can merge |
I confirm the CLA. @Globegitter thanks for picking it up. |
/override cla/google |
@nlopezgi: Overrode contexts on behalf of nlopezgi: cla/google In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
cla overridden with written approval from authors in comments above |
/retest |
This replaces #165 adds some examples as @fejta requested. The build would fail on master but is working on this branch.
Let me know if that is sufficient enough.