-
Notifications
You must be signed in to change notification settings - Fork 135
Conversation
Hi @samschlegel. Thanks for your PR. I'm waiting for a bazelbuild member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
ebeb1f2
to
e808791
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even though the files are empty we problably want to opensource header in them.
Thanks!!
4415e54
to
0758a8d
Compare
Added licenses and rebased! |
@nlopezgi can you get tests running? Is this change ok? |
/assign @nlopezgi |
overall looks good to me, I dont have any way to test the specific use case, but as long as the e2e tests are passing I think this should be fine. Kicked them off. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!!
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: chrislovecnm, samschlegel If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign @nlopezgi EDIT: Oops, sorry! Misread the bot |
We are currently using our own custom resolver that imports
@io_bazel_rules_k8s//k8s:resolver_lib
to run the default resolve pass after our own custom passes. This works fine when our resolver usespar_binary
, but fails when we usepy_binary
. For whatever reason, it seems that the files created bypy_binary.legacy_create_init
aren't included in the runfiles of thek8s_object
rules.There are three ways this could be fixed:
__init__.py
files inpy_binary.attrs.runfiles
execpath
Make variable.__init__.py
files (This PR)Since the expected behaviour moving forward is to include these
__init__.py
files [0], I feel like 3's probably the best option for now, however it seems that 2 might be a better solution[0] https://docs.bazel.build/versions/master/be/python.html#py_binary.legacy_create_init