-
Notifications
You must be signed in to change notification settings - Fork 135
Add support for select statement for k8s_objects. #342
Conversation
Hi @Globegitter. Thanks for your PR. I'm waiting for a bazelbuild member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test Looks good, a rebase would be awesome :) |
@chrislovecnm rebased :) |
Anything still blocking this to get this merged? |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Globegitter, nlopezgi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
apilogies for the delay, thanks for the poke |
We are making use of
--define
flags to deploy targets into different environments. Right now we are making use of analias
to achieve this but it has limitations and adds code complexity that we would like to remove. Unfortunately macros can not manipulateselect
statements directly so I have to treat adict
as a special case. See bazelbuild/bazel#8419