Skip to content
This repository was archived by the owner on Feb 6, 2024. It is now read-only.

fix gazelle #626

Merged
merged 1 commit into from
Apr 30, 2021
Merged

fix gazelle #626

merged 1 commit into from
Apr 30, 2021

Conversation

mariusgrigoriu
Copy link
Contributor

Executing bazel run //:gazelle on master breaks the build due to changes introduced by go_naming_convention and due to the fact that the name of the io_bazel_rules_docker repository rule does not match what gazelle would generate based on the importpath. This PR should allow someone to run gazelle on this repository with breaking things.

@k8s-ci-robot
Copy link

Hi @mariusgrigoriu. Thanks for your PR.

I'm waiting for a bazelbuild member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chases2, mariusgrigoriu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fejta
Copy link
Contributor

fejta commented Dec 4, 2020

/ok-to-test

@mariusgrigoriu
Copy link
Contributor Author

/retest

@mariusgrigoriu
Copy link
Contributor Author

I think the test failure is unrelated. Every test across pull requests since Nov 18 has been timing out.

@fejta
Copy link
Contributor

fejta commented Dec 16, 2020

Thanks, I believe the project where the e2e tests run have had the wrong restrictions put on it, causing these tests to fail. Need to find time to debug this.

@mariusgrigoriu
Copy link
Contributor Author

@fejta Any chance we could get the tests working again soon?

@chases2
Copy link
Contributor

chases2 commented Apr 20, 2021

/retest

@fejta
Copy link
Contributor

fejta commented Apr 30, 2021

/test all

1 similar comment
@fejta
Copy link
Contributor

fejta commented Apr 30, 2021

/test all

@fejta
Copy link
Contributor

fejta commented Apr 30, 2021

How about if we just rename everything following gazelle's modern conventions?

@fejta fejta merged commit 908ff22 into bazelbuild:master Apr 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants