-
Notifications
You must be signed in to change notification settings - Fork 135
Conversation
Hi @mariusgrigoriu. Thanks for your PR. I'm waiting for a bazelbuild member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chases2, mariusgrigoriu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
/retest |
I think the test failure is unrelated. Every test across pull requests since Nov 18 has been timing out. |
Thanks, I believe the project where the e2e tests run have had the wrong restrictions put on it, causing these tests to fail. Need to find time to debug this. |
@fejta Any chance we could get the tests working again soon? |
/retest |
/test all |
1 similar comment
/test all |
How about if we just rename everything following gazelle's modern conventions? |
Executing
bazel run //:gazelle
on master breaks the build due to changes introduced bygo_naming_convention
and due to the fact that the name of theio_bazel_rules_docker
repository rule does not match what gazelle would generate based on the importpath. This PR should allow someone to run gazelle on this repository with breaking things.