Update rules_docker #656
Update rules_docker #656
Conversation
This reverts commit 934d2a1.
|
@fejta: GitHub didn't allow me to request PR reviews from the following users: UebelAndre. Note that only bazelbuild members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
(@UebelAndre any chance you can either respond to the |
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
.bazelci/presubmit.yml
Outdated
| build_targets: | ||
| - "--" | ||
| - "..." | ||
| - "-//images/gcloud-bazel:gcloud_push" |
There was a problem hiding this comment.
I forget, why were these disabled? Seems like they should be enabled
There was a problem hiding this comment.
Probably didn't build at the time or something, let's see if they work now.
|
@googlebot I consent |
Unfortunately I think it might need to be exactly |
|
It says CLA is good to go but @googlebot I consent. |
|
oh sorry my bad! |
|
(I'm used to other repos where there's a label and not just the context, thanks!) |
Thanks for putting this PR together and fixing CI 😄 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chases2, fejta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Also vert 73f62de by reverting 934d2a1
/cc @UebelAndre