This repository was archived by the owner on Sep 16, 2021. It is now read-only.
Do TseTse checks with typechecker later #359
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The typechecker is known to be slow. By moving the non-typechecker checks earlier in the process, I was able to observe significant savings in the `perfTrace.wrap` total times: - `CheckReturnValueRule`: 1,036ms, down from 2,102ms - `MustUsePromisesRule`: 119ms, down from 1,174ms
alexeagle
pushed a commit
to alexeagle/rules_typescript
that referenced
this pull request
Dec 17, 2018
The typechecker is known to be slow to create due to microsoft/TypeScript#27997 By moving the non-typechecker checks earlier in the process, I was able to observe significant savings in the `perfTrace.wrap` total times: - `CheckReturnValueRule`: 1,036ms, down from 2,102ms - `MustUsePromisesRule`: 119ms, down from 1,174ms Closes bazelbuild#359 PiperOrigin-RevId: 225844645
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The typechecker is known to be slow.
By moving the non-typechecker checks earlier in the process, I was able to observe significant savings in the
perfTrace.wraptotal times:CheckReturnValueRule: 1,036ms, down from 2,102msMustUsePromisesRule: 119ms, down from 1,174msIssue Number: angular/angular#27426
Does this PR introduce a breaking change?
Other information