Skip to content

[Issue 8] Handle unregistering of root node #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2019
Merged

Conversation

thomascgray
Copy link
Contributor

@thomascgray thomascgray commented Jun 4, 2019

Fixes #8

When we unregister a node, if its the root node, actually just clear the tree (and associated state) out. the root node is the only node that could ever not have a parent, so handles that as well.

Changelog

  • if unregistering the root node, simple reset the tree and overrides
  • comment in readme
  • new test
  • I ran a format and fixed a bunch of indentations

@thomascgray thomascgray requested review from codan84 and a team June 4, 2019 11:54
@thomascgray thomascgray merged commit 7fdb360 into master Jun 4, 2019
@thomascgray thomascgray deleted the issue-8 branch June 4, 2019 11:57
Copy link
Contributor

@ben-whitfield ben-whitfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unregistering root node causes error
3 participants