Skip to content
This repository was archived by the owner on Aug 7, 2024. It is now read-only.

tweet_volume not being populated for Trend objects #375

Merged
merged 3 commits into from
Jul 29, 2016
Merged

Conversation

jeremylow
Copy link
Collaborator

@jeremylow jeremylow commented Jul 29, 2016

Description

Trend.volume data should be populated on object creation, but because the json data from Twitter is named tweet_volume, this isn't occurring. This changes the property name to be tweet_volume which conforms with Twitter's naming convention and allows the property to be populated straight from the json data.

Additionally, an @property has been added to the Trend object for backwards compatibility.

Related Issue

#374

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

This change is Reviewable

@codecov-io
Copy link

codecov-io commented Jul 29, 2016

Current coverage is 69.15% (diff: 100%)

Merging #375 into master will increase coverage by 0.03%

@@             master       #375   diff @@
==========================================
  Files             8          8          
  Lines          2018       2020     +2   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits           1395       1397     +2   
  Misses          623        623          
  Partials          0          0          

Powered by Codecov. Last update 99e0cff...138ca2e

@bear
Copy link
Owner

bear commented Jul 29, 2016

:lgtm:


Reviewed 3 of 4 files at r1, 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@jeremylow jeremylow merged commit 2f222c7 into master Jul 29, 2016
@jeremylow jeremylow deleted the fix/issue374 branch July 29, 2016 22:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants