Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More CI tragets: Linux 32bit, Windows (MinGW/Wine) and Cosmopolitan #393

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nickva
Copy link
Contributor

@nickva nickva commented Mar 20, 2025

Atomics support in Windows requires libwinpthread*.dll at runtime. One way to get it is to install it with MinGW package, and copy alongside the executable. Update test Makefile targets for windows executables.

Allow running tests with Wine: make WINE=wine CONFIG_WIN3=y .... That's useful when Wine binfmt support cannot be installed such as on the CI hosts.

Fix issue: #390

@nickva nickva force-pushed the more-ci-targets-and-windows-fixes branch 2 times, most recently from e4feb5b to 129b3c1 Compare March 25, 2025 16:17
@bellard
Copy link
Owner

bellard commented Mar 25, 2025

removing pthreads for windows is not needed. You should instead copy the msys pthread library to the current directory before running the tests.

@nickva
Copy link
Contributor Author

nickva commented Mar 25, 2025

will do, thank you

Sorry for misunderstanding, I misunderstood that pthreads wasn't going to work for windows, but I think it's workers that won't work on windows but atomics should.

@nickva nickva force-pushed the more-ci-targets-and-windows-fixes branch from 129b3c1 to 2097f8c Compare March 25, 2025 21:46
@nickva nickva changed the title More ci targets and windows fixes More CI tragets: Linux 32bit, Windows (MinGW/Wine) and Cosmopolitan Mar 25, 2025
@nickva nickva force-pushed the more-ci-targets-and-windows-fixes branch from 2097f8c to 54b562d Compare March 25, 2025 21:56
@nickva
Copy link
Contributor Author

nickva commented Mar 25, 2025

Updated: brought back pthreads for windows, copy winpthreads dll alongside executables and make it easier to run tests with wine. Also added a windows+msys2 and linux LTO target

@nickva nickva force-pushed the more-ci-targets-and-windows-fixes branch 5 times, most recently from 2b7b814 to cd1cb49 Compare March 29, 2025 03:51
…smopolitan

Atomics support in Windows requires libwinpthread*.dll at runtime. One
way to get it is to install it with MinGW package, and copy alongside
the executable.

Update test Makefile targets for windows executables.

Allow running tests with Wine: `make WINE=wine CONFIG_WIN3=y
...`. That's useful when Wine binfmt support cannot be installed such
as on the CI hosts.
@nickva nickva force-pushed the more-ci-targets-and-windows-fixes branch from cd1cb49 to 3590531 Compare March 29, 2025 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants