Use c_char instead of i8 for callback #3

Xeonacid · 2025-02-09T02:31:55Z

c_char is unsigned on platforms like aarch64 and riscv64. Forcing i8 results in a compile error at slice::from_raw_parts_mut [1].

Tested with cargo run --bin sixel --features image -- ./assets/Ada.png

[1]

Line 159 in b41fda5

    
           slice::from_raw_parts_mut(if data.is_null() { return 1 } else { data }, size as usize);

c_char is unsigned on platforms like aarch64 and riscv64. Forcing i8 results in a compile error at `slice::from_raw_parts_mut` [1]. Tested with `cargo run --bin sixel --features image -- ./assets/Ada.png` [1] https://github.com/benjajaja/sixel-bytes/blob/b41fda544a6ade744c9e6f98f1fa9ff876d048f4/src/lib.rs#L159

Same as sixel-bytes PR #3 [0]. c_char is unsigned on platforms like aarch64 and riscv64. Forcing i8 results in a compile error at `slice::from_raw_parts_mut` [1]. Tested with presenterm [2] on both x86_64 and riscv64. [0] benjajaja/sixel-bytes#3 [1] https://github.com/benjajaja/sixel-bytes/blob/b41fda544a6ade744c9e6f98f1fa9ff876d048f4/src/lib.rs#L159 [2] https://gitlab.archlinux.org/archlinux/packaging/packages/presenterm/-/blob/main/PKGBUILD

Xeonacid mentioned this pull request Feb 9, 2025

Use c_char instead of i8 for callback orhun/sixel-rs#6

Merged

Provide feedback