Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change current book to quick start guide #880

Merged

Conversation

TrialDragon
Copy link
Member

Changes references inside the quick start guide from book to quick start guide, fixes links inside of the quick start guide that used to go to the book. It also clarifies and fixes the last section in next steps.

Closes #875
Fixes #261

Copy link
Contributor

@hymm hymm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commented about a couple links that 404'ed. Should be ready to go after those are fixed.

@hymm
Copy link
Contributor

hymm commented Jan 21, 2024

found one more 404 in getting-started\setup\_index.md line 205 "troubleshooting section"

@hymm
Copy link
Contributor

hymm commented Jan 21, 2024

some of the blog posts link to /learn/book/introduction should there be an alias for that to /learn/getting-started/introduction?

@TrialDragon
Copy link
Member Author

TrialDragon commented Jan 21, 2024

some of the blog posts link to /learn/book/introduction should there be an alias for that to /learn/getting-started/introduction?

The plan is to change all of those in #878 I believe. Probably switch them to the /learn/book/quick-start link. But if it is desired I can push it up to this PR.

@hymm
Copy link
Contributor

hymm commented Jan 21, 2024

The plan is to change all of those in #878 I believe. Probably switch them to the /learn/book/quick-start link. But if it is desired I can push it up to this PR.

I don't have the data to say whether we should clean those up or not. Depends on how much traffic those pages are getting. If I had to guess it'd probably be ok to let the be broken for a day or two, but hard to say for sure.

@TrialDragon
Copy link
Member Author

TrialDragon commented Jan 21, 2024

I don't have the data to say whether we should clean those up or not. Depends on how much traffic those pages are getting. If I had to guess it'd probably be ok to let the be broken for a day or two, but hard to say for sure.

I mean, it's not touching the deployed site afaik. This PR is only targeting new-book, not main This will be fixed before we merge new-book into main.

Copy link
Contributor

@hymm hymm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good other than the broken links to /learn/book/introduction in the news posts. @alice-i-cecile your call whether we should fix it in this pr or a follow up.

@alice-i-cecile
Copy link
Member

Let's fix those broken links here.

@alice-i-cecile alice-i-cecile merged commit 81bae00 into bevyengine:new-book Jan 22, 2024
@TrialDragon TrialDragon deleted the 875_book_to_quick_start_guide branch January 22, 2024 05:28
github-merge-queue bot pushed a commit to bevyengine/bevy that referenced this pull request Feb 19, 2024
# Objective

Since bevyengine/bevy-website#880, the old book
is now the Quick Start Guide, but the references to the old book have
not been updated.

## Solution

Update references to the old book to point to the Quick Start Guide.
msvbg pushed a commit to msvbg/bevy that referenced this pull request Feb 26, 2024
# Objective

Since bevyengine/bevy-website#880, the old book
is now the Quick Start Guide, but the references to the old book have
not been updated.

## Solution

Update references to the old book to point to the Quick Start Guide.
msvbg pushed a commit to msvbg/bevy that referenced this pull request Feb 26, 2024
# Objective

Since bevyengine/bevy-website#880, the old book
is now the Quick Start Guide, but the references to the old book have
not been updated.

## Solution

Update references to the old book to point to the Quick Start Guide.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants