Skip to content

Isolate indexes #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Feb 1, 2018
Merged

Isolate indexes #37

merged 20 commits into from
Feb 1, 2018

Conversation

dcousens
Copy link
Contributor

No description provided.

@dcousens dcousens added this to the 0.9.0 milestone Jan 25, 2018
@dcousens dcousens self-assigned this Jan 25, 2018
@dcousens dcousens mentioned this pull request Jan 25, 2018
Closed
KryptoNova
KryptoNova reviewed Jan 26, 2018
View reviewed changes
example/service.js Outdated
let debugZmq = require('debug')('service:zmq')
let debugZmqTx = require('debug')('service:zmq:tx')
// let indexd = require('indexd') // XXX: you should use npm published package typically
let indexd = require('../')
let Indexd = require('../indexd') // FIXME: use require('indexd') in production
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line change breaks the example.
I think it should be:
let Indexd = require('../')

@KryptoNova
Copy link

This is definitely an exciting PR. Great work!!

I was testing this modification and I think the example service is broken. I made a note on one problem that I found. I think there is still another problem in the example. I got an error in the socket.js file inside of the example. See below:

socket.js:31
adapter.emitter.on('block', (blockId) => {
        ^

TypeError: Cannot read property 'emitter' of undefined

@dcousens
Copy link
Contributor Author

dcousens commented Jan 29, 2018 •
edited
Loading

@KryptoNova indeed thanks for testing! The PR is still WIP, but it is nearly done.
I'll ensure to ping you in when this is ready for merge (and therefore, non-alpha-like testing too!).

This was referenced Jan 30, 2018
Closed
Closed
@dcousens dcousens force-pushed the isoindex branch 2 times, most recently from 830d723 to 4cf7763 Compare January 30, 2018 07:56
@dcousens
Copy link
Contributor Author

@KryptoNova go! This is ready for testing now. I am using it for bitcoinjs' regtest server for integration testing, which is where I have moved the example/ folder to.

@dcousens dcousens merged commit 71be466 into master Feb 1, 2018
@dcousens dcousens deleted the isoindex branch February 1, 2018 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KryptoNova KryptoNova KryptoNova left review comments

Assignees

@dcousens dcousens

Labels
feature
Projects
None yet
Milestone
0.9.0
Development

Successfully merging this pull request may close these issues.
2 participants
@dcousens @KryptoNova