Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed folders that are empty. #80

Closed
wants to merge 3 commits into from

Conversation

kashishlubana
Copy link

#78 has been resolved.
@blavejr both the suggestions,

  1. Remove folders that are created by this program but don't have any files inside (or just don't create them in the first place)
  2. Make a new option to remove empty folders on the desktop.

have been solved.

@blavejr
Copy link
Owner

blavejr commented Apr 1, 2020

I will check out your PR and merge it if it's ok. Thanks alot for your help. It's really appreciated.

@kashishlubana
Copy link
Author

Option number (1) was fixed by @KokoseiJ. I just built on top of it.

@KokoseiJ
Copy link
Collaborator

KokoseiJ commented Apr 7, 2020

Nice, Thank you very much.

Copy link
Collaborator

@KokoseiJ KokoseiJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a quick review. I'm not a professional dev but those parts might need some changes.

@@ -3,6 +3,7 @@
import os
from cronController import schedule_end, schedule_start
from organiseDesktop import undo, organise_desktop
from os import path, mkdir, listdir, rename, environ, rmdir
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be a bit of an overreaction, but Wouldn't it be better to just use os module instead of importing those functions again, just like other contributors did, for the sake of consistency of the code style?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, you are right, or just import the needed ones but not both. Give it a go :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants