Removed folders that are empty. #80
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will check out your PR and merge it if it's ok. Thanks alot for your help. It's really appreciated. |
|
Option number (1) was fixed by @KokoseiJ. I just built on top of it. |
|
Nice, Thank you very much. |
KokoseiJ
requested changes
Apr 22, 2020
| @@ -3,6 +3,7 @@ | |||
| import os | |||
| from cronController import schedule_end, schedule_start | |||
| from organiseDesktop import undo, organise_desktop | |||
| from os import path, mkdir, listdir, rename, environ, rmdir | |||
There was a problem hiding this comment.
This might be a bit of an overreaction, but Wouldn't it be better to just use os module instead of importing those functions again, just like other contributors did, for the sake of consistency of the code style?
There was a problem hiding this comment.
Yep, you are right, or just import the needed ones but not both. Give it a go :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#78 has been resolved.
@blavejr both the suggestions,
have been solved.