remove alen from imports #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't know why the tests are failing, is it because of the change I made? |
|
@tinosulzer No, it looks fine to me. Thanks for fixing this. |
|
Thanks for the quick review. Will there be a new release soon, or should we change to pip install from master for now? |
moorepants
added a commit
to moorepants/learn-multibody-dynamics
that referenced
this pull request
Jun 25, 2022
See: bmcage/odes#136 where the issues has been fixed in scikits.odes. The next release will work with NumPy 1.23.
|
Uploaded to PyPI now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newest version of
numpyerrors whenalenis imported, see for example https://github.com/pybamm-team/PyBaMM/runs/7017620061?check_suite_focus=true#step:11:28This PR removes
alenfrom the python imports, and replacesalenwithlenwhere appropriate