Improve projections' parameters handling. #468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace pj_param() taking type of parameter in a string with a set of functions: - pj_param_exist() - check if a parameter exists, - pj_param_X() - check if a parameter exists and assign it to variable, - pj_get_param_X() - return parameter if it exists or default value, may be: - s (returning std::string), - i (int), - f (floating point or user-defined numeric type), - r (angle defined in DMS format as radians in FP or UD type), - b (bool) Use the above e.g. to avoid traversing parameters list twice per parameter in some cases. Add pj_mkparam() overload taking name and value as separate arguments to avoid parsing of string in 'param=value' format.
|
Looks ok to me, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the same changes as closed #461 but it's implemented on top of #465.
In short it allows to replace this:
with this:
and this:
with this:
So the information about the parameter type is expressed in compile-time as function name instead of passed as character in cstring. But most importantly the function doesn't have to be called twice to check if the parameter is set and then get it.