Allow other host for oauth response redirect #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willtcarey
approved these changes
Feb 12, 2024
| @@ -18,7 +18,7 @@ def create | |||
| oauth_response.code = authorization.code | |||
| oauth_response.redirect_uri = @redirect_uri | |||
| oauth_response.approve! | |||
| redirect_to oauth_response.location | |||
| redirect_to oauth_response.location, allow_other_host: true | |||
There was a problem hiding this comment.
Just chiming in to say that while this option only got supported in Rails 7, it looks like it should just be a no-op as far back as Rails 5.
(The second option would be passed in as the response status which is only looking for a specific status key in Rails 5 and 6)
willtcarey
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #18