Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ::mylib which that target that exists at configure-time #169

Merged
merged 3 commits into from
Dec 4, 2024
+45 −11
Merged

Support ::mylib which that target that exists at configure-time #169

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
38cec2d
Do not allow lambdas on a single line
mrexodia Dec 4, 2024
0f2a9a5
Support link-libraries = ["::mylib"] which checks the if target exists
mrexodia Dec 4, 2024
e318139
Add documentation for `::mylib`
mrexodia Dec 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Support link-libraries = ["::mylib"] which checks the if target exists 
https://gitlab.kitware.com/cmake/cmake/-/issues/26497
@mrexodia
mrexodia committed Dec 4, 2024
commit 0f2a9a55fbf510414149caecaedabdce9da92c4b
24 changes: 22 additions & 2 deletions src/cmake_generator.cpp
View file
Original file line number Diff line number Diff line change
@@ -1401,6 +1401,26 @@ void generate_cmake(const char *path, const parser::Project *parent_project) {
});
};

auto link_libraries = [&](const parser::ConditionVector &cargs, const std::string &scope) {
gen.handle_condition(cargs, [&](const std::string &, const std::vector<std::string> &args) {
std::vector<std::string> targs;
for (const std::string &arg : args) {
if (arg.find("::") == 0) {
auto library = arg.substr(2);
// clang-format off
cmd("if")("NOT", "TARGET", library);
cmd("message")("FATAL_ERROR", "Target \"" + library + "\" referenced by \"" + target.name + "\" does not exist!");
cmd("endif")().endl();
// clang-format on
targs.push_back(std::move(library));
} else {
targs.push_back(arg);
}
}
cmd("target_link_libraries")(target.name, scope, targs);
});
};

auto gen_target_cmds = [&](const parser::Target &t) {
target_cmd("target_compile_definitions", t.compile_definitions, target_scope);
target_cmd("target_compile_definitions", t.private_compile_definitions, "PRIVATE");
@@ -1417,8 +1437,8 @@ void generate_cmake(const char *path, const parser::Project *parent_project) {
target_cmd("target_link_directories", t.link_directories, target_scope);
target_cmd("target_link_directories", t.private_link_directories, "PRIVATE");

target_cmd("target_link_libraries", t.link_libraries, target_scope);
target_cmd("target_link_libraries", t.private_link_libraries, "PRIVATE");
link_libraries(t.link_libraries, target_scope);
link_libraries(t.private_link_libraries, "PRIVATE");

target_cmd("target_link_options", t.link_options, target_scope);
target_cmd("target_link_options", t.private_link_options, "PRIVATE");