Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reverse_proxy: re-add healthy upstreams metric #6806

Merged
merged 4 commits into from
Jan 27, 2025
Merged

reverse_proxy: re-add healthy upstreams metric #6806

merged 4 commits into from
Jan 27, 2025

Conversation

mohammed90
Copy link
Member

I'm not a fan of storing the state in the active context, but it seems to be the only way to catch if this is a reload of Caddy or a fresh start.

Fixes #6773

Signed-off-by: Mohammed Al Sahaf <msaa1990@gmail.com>
@mohammed90 mohammed90 added bug 🐞 Something isn't working under review 🧐 Review is pending before merging labels Jan 24, 2025
@mohammed90 mohammed90 marked this pull request as ready for review January 24, 2025 22:16
Copy link
Member

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I don't fully understand the metrics side of things, but if this fixes it, LGTM - thanks!)

@mholt mholt merged commit 904a0fa into master Jan 27, 2025
33 checks passed
@mholt mholt deleted the issue-6773 branch January 27, 2025 21:30
@mholt mholt removed the under review 🧐 Review is pending before merging label Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐞 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

caddy_reverse_proxy_upstreams_healthy missing in metrics page
2 participants