AnalogueKeyboard: Fix crashing with Keychron/Lemokey keyboards #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've found a solution to AnalogSense/universal-analog-plugin#6 that works reliably. Now we don't send version reports on discovery requests, but when the actual keys are polled. The version requested only once and the result is encoded in
keychron.state(where 0 - unknown, 1 - single key, ff - full report). I've also adjusted the single key to work with the new state encoding.Tested on Lemokey P1 HE in the wooting midi app and in Cyberpunk with both single key and full report modes.