Skip to content

Building Fabric View + Turbo Module #728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
satya164 opened this issue Dec 13, 2024 · 0 comments · Fixed by #736
Closed

Building Fabric View + Turbo Module #728

satya164 opened this issue Dec 13, 2024 · 0 comments · Fixed by #736

Comments

@satya164
Copy link
Member

Discussed in #726

Originally posted by ian-wd December 9, 2024
Is it possible atm to build a Fabric view along with a turbo module?

I was trying to get it working like how rn-skia does it but I can't get it working via builder-bob

here's a video showing my problem:
https://github.com/user-attachments/assets/499e92ed-7fab-4c37-997b-d0247135b7dc

seems like whenever I add a turbo module spec it doesn't generate the delegate and interface java files

@atlj atlj closed this as completed in #736 Jan 28, 2025
atlj added a commit that referenced this issue Jan 28, 2025
### Summary

Fixes #728

The codegen patcher script was deleting the whole `facebook` namespace
when the codegen type was all or module. This was not a problem when the
type was module but when the type was all, view manager specs were also
getting removed.s

### Test plan

1. Create a new turbo module
2. Set codegen type to all
3. Add turbo module specs
4. Run `yarn bob build --target codegen`
5. Make sure `android/generated/java/com/facebook/react` exists and has
view manager specs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant