feat: add disable prop to RadioButton.Item #1721
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nkzn
force-pushed
the
nkzn-radiobuttonitem-disabled
branch
from
32a1127 to
8ee69c9
Compare
|
@Trancever Could you please review this PR? |
|
@Nkzn Thanks for your contribution! Could you resolve the conflicts? An example app is rewritten to use hooks now. |
|
I am closing this in favour of #1900 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
RadioButton(.Android|.IOS)?hasdisabledprop, butRadioButton.Itemdoes not.Test plan
Use example. "Normal 3 - Item", "Checked - Item (Disabled)" and "Unchecked - Item (Disabled)" are made by
RadioButton.Item.