fix: fab custom icon click and animation #1896
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trancever
pushed a commit
that referenced
this pull request
May 26, 2020
marchenk0va
pushed a commit
to marchenk0va/react-native-paper
that referenced
this pull request
Jun 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
#1876
FAB was not working properly when a function was passed to the icon prop. There was no animation and the icon didn't change according to a state.
I assume that after enabling using custom icons in FAB, sb forgot to add a new type to isValidIcon.
Before:
After:
Test plan
Reproduce the scenario in #1876