Add fabric on iOS #400
Merged
Add fabric on iOS #400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is part of #380 - linking this to the issue. |
BartoszKlonowski
force-pushed
the
chore/fabric-setup
branch
from
0db2976 to
3e5fde1
Compare
There was a problem hiding this comment.
note: I've allowed myself to rebase your branch, as I saw there's a leftover in package lockfile with old npm version (your PR updates it correctly, but the updated version should be on main branch). I updated it on main and rebased your branch to avoid potential conflicts - sorry for inconvenience.
BartoszKlonowski
force-pushed
the
chore/fabric-setup
branch
from
c030233 to
8195867
Compare
| device=$(xcrun simctl list devices "${device_name}" available | grep "${device_name} (") | ||
| re='\(([-0-9A-Fa-f]+)\)' | ||
| [[ $device =~ $re ]] || exit 1 | ||
| xcodebuild -workspace example.xcworkspace -scheme example -destination "platform=iOS Simulator,id=${BASH_REMATCH[1]}" CODE_SIGNING_ALLOWED=NO COMPILER_INDEX_STORE_ENABLE=NO build |
There was a problem hiding this comment.
Just wondering: Don't we have COMPILER_INDEX_STORE_ENABLED set to NO by default?
There was a problem hiding this comment.
It defaults to YES, and it gives us major speed improvements. Check this out:
satya164
reviewed
Jul 28, 2022
* Bring back Pods to cache * Use new-arch string in key for new arch cache * Try to reinstall pods instead of creating new * Separate deps installation between two caches * Rename Pods reinstall step
BartoszKlonowski
approved these changes
Jul 28, 2022
This check is no longer needed.
BartoszKlonowski
approved these changes
Aug 2, 2022
Merged
okwasniewski
added a commit
that referenced
this pull request
Aug 8, 2022
* Add fabric on iOS (#400) * Update podspec file for fabric * Define codegen spec & move import to separate file * Add codegenConfig in package.json * Update podspec to detect .mm files * Change spec types to floats * Implement fabric component with props updating * Re-order functions, add accessibilityIncrements prop * Clean up imports, remove comment * Sort out props updating, remove unused functions * Add event handling * Add tapToSeek implementation * Fix tapToSeek * Handle images using bridge * Add missing typedef * Verify the build for new arch with GH Actions * Save new-arch Pods under new-arch cache key * Use Podfile.lock with old arch and regenerate for new one * Correct path for new arch Podfile.lock creation * Disable flipper in Podfile * Install pods with new arch flag * Fix tapToSeek on iOS * Allow value property to be controlled * Generate project.pbxproj for new arch * Separate npm & pods step in CI * Change step names, fix cache keys * Remove pods cache * Run npm install if cache was not found * Run build using xcodebuild * Fix: Pods-related error after using Pods from cache (#407) * Bring back Pods to cache * Use new-arch string in key for new arch cache * Try to reinstall pods instead of creating new * Separate deps installation between two caches * Rename Pods reinstall step * Remove explicit folly version, default to old arch * Add clean scripts in example for codegen cleanup * Change CI step names * Remove isFabricEnabled This check is no longer needed. Co-authored-by: BartoszKlonowski <Bartosz.Klonowski@callstack.com> * Add fabric on Android (#402) * Configure build.gradle * Update libraryName on android * Create ReactSlider shared implementation * Split implementations into oldarch and newarch * Dispatch events * Cleanup eventDispatcher * Make oldarch implementation use shared code * Add defaults to js spec * Clean up newarch ReactSliderManager * Reorder props to fix disabled state * Handle TestID setter * Move ReactSliderShadowNode to shared implementation * Share getExportedCustomDirectEventTypeConstants * Remove comments, add empty line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
requireNativeComponentto separate fileTest Plan:
iOS: Install pods using
RCT_NEW_ARCH_ENABLED=1 pod install