Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(zbchaos): add command for broker scaling #464

Merged
merged 5 commits into from
Dec 19, 2023

Conversation

lenaschoenburg
Copy link
Member

@lenaschoenburg lenaschoenburg commented Dec 14, 2023

Adds a new command that makes an API call to Zeebe to scale to the given amount of brokers and then scales up the statefulset accordingly. The command knows if it is scaling up or down to scale the statefulset first or last. The command always waits for completion as it can only scale down the statefulset after the change is applied.

Usage:

$ zbchaos cluster scale --brokers 5

Part 2/X of #458

@lenaschoenburg lenaschoenburg marked this pull request as draft December 14, 2023 09:13
Copy link
Member

@ChrisKujawa ChrisKujawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great @oleschoenburg 👍🏼

One remark regarding the printing, others are more nitpicks, questions/ideas.

@lenaschoenburg
Copy link
Member Author

@Zelldon Thanks for the review so far 👍 I just realized that this doesn't work for scaling down because there we need to make the API request first, wait for the change to complete and only then scale down the statefulset. I'll fix this first before merging.

@lenaschoenburg lenaschoenburg force-pushed the os/support-dynamic-scaling branch from 52bbd9e to bf5efce Compare December 18, 2023 11:16
@lenaschoenburg lenaschoenburg marked this pull request as ready for review December 18, 2023 11:52
@lenaschoenburg lenaschoenburg force-pushed the os/support-dynamic-scaling branch from bf5efce to d2f521c Compare December 18, 2023 14:55
@lenaschoenburg
Copy link
Member Author

Rebased on main to get the local port improvement

Copy link
Member

@ChrisKujawa ChrisKujawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Cool stuff! Thanks @oleschoenburg

@lenaschoenburg lenaschoenburg merged commit a6694f3 into main Dec 19, 2023
@lenaschoenburg lenaschoenburg deleted the os/support-dynamic-scaling branch December 19, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants