-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(zbchaos): add command for broker scaling #464
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great @oleschoenburg 👍🏼
One remark regarding the printing, others are more nitpicks, questions/ideas.
@Zelldon Thanks for the review so far 👍 I just realized that this doesn't work for scaling down because there we need to make the API request first, wait for the change to complete and only then scale down the statefulset. I'll fix this first before merging. |
52bbd9e
to
bf5efce
Compare
bf5efce
to
d2f521c
Compare
Rebased on main to get the local port improvement |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 Cool stuff! Thanks @oleschoenburg
Adds a new command that makes an API call to Zeebe to scale to the given amount of brokers and then scales up the statefulset accordingly. The command knows if it is scaling up or down to scale the statefulset first or last. The command always waits for completion as it can only scale down the statefulset after the change is applied.
Usage:
Part 2/X of #458