Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spread: enable cross distro reexec test suite on openSUSE #15201

Merged
merged 2 commits into from
Mar 20, 2025

Conversation

bboozzoo
Copy link
Contributor

@bboozzoo bboozzoo commented Mar 13, 2025

Add openSUSE to set of systems on which we run cross distro with snapd
reexec test suite.

Depends on #15197

Related: SNAPDENG-34646

Thanks for helping us make a better snapd!
Have you signed the license agreement and read the contribution guide?

@bboozzoo bboozzoo added cross-distro Runs all spread systems in parallel ⛔ Blocked labels Mar 13, 2025
@bboozzoo
Copy link
Contributor Author

We need to get the openSUSE TW images updated and functional first.

Copy link

codecov bot commented Mar 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.15%. Comparing base (d6d95f0) to head (5c3e407).
Report is 28 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #15201      +/-   ##
==========================================
+ Coverage   78.09%   78.15%   +0.05%     
==========================================
  Files        1190     1187       -3     
  Lines      158458   158776     +318     
==========================================
+ Hits       123746   124088     +342     
+ Misses      27017    26977      -40     
- Partials     7695     7711      +16     
Flag Coverage Δ
unittests 78.15% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

github-actions bot commented Mar 13, 2025

Thu Mar 20 09:24:11 UTC 2025

Spread tests skipped

@bboozzoo
Copy link
Contributor Author

The snap command reexecs correctly, but snapd does not, probably due to the fact that our logic assumes a binary exists at identical path within the snapd snap. In case of TW, snapd is at /usr/libexec/snapd/snapd, hence a check for /snap/snapd/current/usr/libexec/snapd fails and reexec is not executed.

Add openSUSE to set of systems on which we run cross distro with snapd
reexec test suite.

Signed-off-by: Maciej Borzecki <maciej.borzecki@canonical.com>
@bboozzoo bboozzoo force-pushed the bboozzoo/opensuse-reexec-tests branch from dab9db5 to f5a8543 Compare March 19, 2025 13:31
Depending on whether it's Leap or Tumbleweed pidof is provided by one of
those packages.

Signed-off-by: Maciej Borzecki <maciej.borzecki@canonical.com>
@bboozzoo bboozzoo force-pushed the bboozzoo/opensuse-reexec-tests branch from f5a8543 to 5c3e407 Compare March 19, 2025 18:21
@bboozzoo bboozzoo added the Skip spread Indicate that spread job should not run label Mar 20, 2025
@bboozzoo bboozzoo closed this Mar 20, 2025
@bboozzoo bboozzoo reopened this Mar 20, 2025
@bboozzoo bboozzoo merged commit 890ef46 into canonical:master Mar 20, 2025
148 of 152 checks passed
@bboozzoo bboozzoo deleted the bboozzoo/opensuse-reexec-tests branch March 20, 2025 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cross-distro Runs all spread systems in parallel Skip spread Indicate that spread job should not run
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants