tests: fix overeager chmod -x in restore #15232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zyga
added
Simple 😃
|
Mon Mar 24 08:49:01 UTC 2025 Spread tests skipped |
bboozzoo
reviewed
Mar 24, 2025
| @@ -40,7 +40,7 @@ execute: | | |||
| # small hole to allow that. | |||
| chmod +x /run/user/"$(id -u test)" ~test | |||
| # The runtime directory will be removed by now. | |||
| tests.cleanup defer chmod -x ~test | |||
| tests.cleanup defer chmod o-x ~test | |||
There was a problem hiding this comment.
can you stat -c '%a' ~test before and restore the same in defer?
The intent was to remove the x permission in the "other" group, not for everyone. Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>
zyga
force-pushed
the
fix/chmod-test-sorry
branch
from
0220055 to
4a96f8f
Compare
maykathm
approved these changes
Mar 24, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #15232 +/- ##
========================================
Coverage 78.09% 78.10%
========================================
Files 1190 1192 +2
Lines 158458 159146 +688
========================================
+ Hits 123746 124296 +550
- Misses 27017 27117 +100
- Partials 7695 7733 +38
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intent was to remove the x permission in the "other" group, not for everyone.