Skip to content

Pin cython to below version 3, Python 3.11 support #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 21, 2023

Conversation

kvelicka
Copy link
Contributor

@kvelicka kvelicka commented Jul 20, 2023

Cython 3 includes backwards incompatible changes so it's no longer possible to install pycapnp from source.

I'm not sure if that tox file change is enough to start running CI for 3.11, but I'm much less worried about that part than the broken builds.

Fixes #319

kvelicka added 2 commits July 20, 2023 15:28
Cython 3 includes backwards incompatible changes so it's no longer
possible to install pycapnp from source.
I'm not sure if this is necessary, but 3.11 is out so might as well?
@haata
Copy link
Collaborator

haata commented Jul 20, 2023

tox.ini isn't used within GitHub Actions so I believe we already have Python 3.11 support.

v1.3.0 already has python 3.11 wheels.
https://pypi.org/project/pycapnp/#files

But your fix is appreciated regardless 👍

@haata haata merged commit db26d60 into capnproto:master Jul 21, 2023
@kvelicka
Copy link
Contributor Author

Yep apologies for ignorance, I'm not quite up to date with the myriad of ways in which python packaging/github actions are configured 😅

@alex-reilly-pronto
Copy link

Is there any way to fix this for older versions as well? We're running 1.1.0

@kvelicka
Copy link
Contributor Author

Would it be possible to release a new version with these pins on PyPI?

@fungs
Copy link

fungs commented Jan 16, 2024

I'm running into this issue with a project on Python 3.12. Pip install fails as there is no prebuilt wheel for it, I assume. For now, I got around it using the cython constraint workaround in #319 and bundling upstream capnproto v1.0.2 into the package build.

However, the easier way to fix the for my development stage now was to install the beta like pip install pycapnp==2.0.0b2.

@haata
Copy link
Collaborator

haata commented Jan 19, 2024

I'll try to push the 2.0.0 in the next few days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't build pip package with Cython 3.0.0
4 participants