Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📝 Run python docstring generator on forks during PRs #475

Merged
merged 1 commit into from
Jul 18, 2024
Merged

📝 Run python docstring generator on forks during PRs #475

merged 1 commit into from
Jul 18, 2024

Conversation

simon1hofmann
Copy link
Collaborator

@simon1hofmann simon1hofmann commented Jul 17, 2024 •
edited
Loading

Description

The python docstring generator stopped working on PRs from forks. Adding on: pull_request should fix that.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have added a changelog entry.
  • I have created/adjusted the Python bindings for any new or updated functionality.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@simon1hofmann simon1hofmann requested a review from marcelwa July 17, 2024 17:25
@simon1hofmann simon1hofmann self-assigned this Jul 18, 2024
@simon1hofmann simon1hofmann added the github_actions Pull requests that update GitHub Actions code label Jul 18, 2024
marcelwa
marcelwa approved these changes Jul 18, 2024
View reviewed changes
Copy link
Collaborator

@marcelwa marcelwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks!

@marcelwa marcelwa merged commit c6034ee into cda-tum:main Jul 18, 2024
3 checks passed
@simon1hofmann simon1hofmann mentioned this pull request Jul 18, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcelwa marcelwa marcelwa approved these changes

Assignees

@simon1hofmann simon1hofmann

Labels
github_actions Pull requests that update GitHub Actions code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simon1hofmann @marcelwa