Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚸 Add warning for leak sanitizer usage with AppleClang #482

Merged
merged 2 commits into from
Jul 24, 2024

Conversation

Drewniok
Copy link
Collaborator

Description

This PR introduces a warning when Leak Sanitizer is used with Apple Clang, as it is incompatible with this compiler.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have added a changelog entry.
  • I have created/adjusted the Python bindings for any new or updated functionality.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@Drewniok Drewniok added the compiler issue A platform-dependent problem label Jul 23, 2024
@Drewniok Drewniok self-assigned this Jul 23, 2024
@Drewniok Drewniok changed the title 🚸 Improve warning for leak sanitizer usage with apple clang 🚸 Add warning for leak sanitizer usage with apple clang Jul 23, 2024
@marcelwa marcelwa changed the title 🚸 Add warning for leak sanitizer usage with apple clang 🚸 Add warning for leak sanitizer usage with AppleClang Jul 23, 2024
Copy link

codecov bot commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.21%. Comparing base (308adf9) to head (66924ae).
Report is 62 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #482      +/-   ##
==========================================
- Coverage   98.22%   98.21%   -0.01%     
==========================================
  Files         216      216              
  Lines       29157    29157              
  Branches     1389     1389              
==========================================
- Hits        28639    28638       -1     
- Misses        518      519       +1     

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 308adf9...66924ae. Read the comment docs.

@Drewniok Drewniok requested a review from marcelwa July 24, 2024 05:25
@marcelwa marcelwa merged commit fd528c7 into cda-tum:main Jul 24, 2024
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler issue A platform-dependent problem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants