Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚨 Fixed clang-tidy warnings. #519

Merged
merged 4 commits into from
Sep 2, 2024
Merged

Conversation

Drewniok
Copy link
Collaborator

@Drewniok Drewniok commented Sep 1, 2024

Description

This PR implements a few clang-tidy warnings.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have added a changelog entry.
  • I have created/adjusted the Python bindings for any new or updated functionality.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@Drewniok Drewniok self-assigned this Sep 1, 2024
@Drewniok Drewniok added the small fix Non-critical issue or inconsistency label Sep 1, 2024
Copy link

codecov bot commented Sep 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.15%. Comparing base (5c1bac7) to head (821e403).
Report is 77 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #519   +/-   ##
=======================================
  Coverage   98.15%   98.15%           
=======================================
  Files         224      224           
  Lines       31303    31300    -3     
  Branches     1563     1563           
=======================================
- Hits        30726    30724    -2     
+ Misses        577      576    -1     
Files with missing lines Coverage Δ
...on/algorithms/optimization/simulated_annealing.hpp 100.00% <ø> (ø)
...n/algorithms/physical_design/design_sidb_gates.hpp 98.23% <ø> (ø)
...tion/sidb/assess_physical_population_stability.hpp 96.59% <ø> (ø)
...lgorithms/simulation/sidb/critical_temperature.hpp 97.32% <ø> (ø)
...simulation/sidb/displacement_robustness_domain.hpp 97.53% <ø> (ø)
...maximum_defect_influence_position_and_distance.hpp 100.00% <ø> (ø)
.../sidb/occupation_probability_of_excited_states.hpp 96.66% <ø> (ø)
.../fiction/algorithms/simulation/sidb/quickexact.hpp 98.77% <ø> (-0.02%) ⬇️
...s/simulation/sidb/random_sidb_layout_generator.hpp 95.55% <ø> (ø)
...on/algorithms/simulation/sidb/time_to_solution.hpp 100.00% <ø> (+2.43%) ⬆️
... and 4 more

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c1bac7...821e403. Read the comment docs.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

@Drewniok Drewniok merged commit 671f9b3 into cda-tum:main Sep 2, 2024
61 checks passed
@Drewniok Drewniok deleted the clang_tidy_warning branch September 2, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
small fix Non-critical issue or inconsistency
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants