Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Multithreading support for gold #529

Merged
merged 47 commits into from
Oct 7, 2024
Merged

✨ Multithreading support for gold #529

merged 47 commits into from
Oct 7, 2024

Conversation

simon1hofmann
Copy link
Collaborator

@simon1hofmann simon1hofmann commented Sep 23, 2024 •
edited
Loading

Description

Enable multithreading for gold.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have added a changelog entry.
  • I have created/adjusted the Python bindings for any new or updated functionality.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

simon1hofmann and others added 30 commits August 30, 2024 09:34
@simon1hofmann
working solution
eb9411b
@simon1hofmann
Merge branch 'cda-tum:main' into gold_cost_functions
c0ffd5b
@actions-user
📝 Update pyfiction docstrings
7052f8c 
Signed-off-by: GitHub Actions <actions@github.com>
@simon1hofmann
Merge branch 'cda-tum:main' into gold_cost_functions
0cfac62
@simon1hofmann
structure
a228dfb
@simon1hofmann
Merge remote-tracking branch 'origin/gold_cost_functions' into gold_c…
05e474a 
…ost_functions
@simon1hofmann
cost objectives
152a335
@actions-user
📝 Update pyfiction docstrings
470771d 
Signed-off-by: GitHub Actions <actions@github.com>
@simon1hofmann
add bindings
d999c8f
@simon1hofmann
clean-up
8d1173c
@simon1hofmann
benchmark
f11e096
@actions-user
📝 Update pyfiction docstrings
c1a4fc0 
Signed-off-by: GitHub Actions <actions@github.com>
@simon1hofmann
Merge branch 'main' into gold_cost_functions
1deb773
@simon1hofmann
increase coverage
5203e35
@simon1hofmann
Merge remote-tracking branch 'origin/gold_cost_functions' into gold_c…
6dcaa86 
…ost_functions
@simon1hofmann
clang-tidy
ca245c5
@simon1hofmann
small fix
e777d29
@simon1hofmann
code review
c205b2a
@actions-user
📝 Update pyfiction docstrings
c2b7556 
Signed-off-by: GitHub Actions <actions@github.com>
@simon1hofmann
Merge branch 'main' into gold_cost_functions
4d78d12
@simon1hofmann
bug fixes
bba3919
@simon1hofmann
Merge remote-tracking branch 'origin/gold_cost_functions' into gold_c…
c67585b 
…ost_functions
@actions-user
📝 Update pyfiction docstrings
244f152 
Signed-off-by: GitHub Actions <actions@github.com>
@simon1hofmann
formatting
c26e5db
@simon1hofmann
missing header
7abf365
@simon1hofmann
100% test coverage
27199a4
@simon1hofmann
more tests
d13581f
@simon1hofmann
multithreading
32a63f3
@actions-user
📝 Update pyfiction docstrings
af4ee2a 
Signed-off-by: GitHub Actions <actions@github.com>
@simon1hofmann
Merge branch 'main' into gold_multithreading
584f824 
Signed-off-by: simon1hofmann <119581649+simon1hofmann@users.noreply.github.com>
github-actions[bot]
github-actions bot reviewed Sep 23, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

simon1hofmann and others added 2 commits September 24, 2024 20:14
@simon1hofmann
use atomics instead of mutex
8eead9a
@actions-user
📝 Update pyfiction docstrings
e9b4960 
Signed-off-by: GitHub Actions <actions@github.com>
github-actions[bot]
github-actions bot reviewed Sep 24, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

github-actions[bot]
github-actions bot reviewed Sep 25, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

github-actions[bot]
github-actions bot reviewed Sep 25, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

@simon1hofmann simon1hofmann self-assigned this Sep 25, 2024
@simon1hofmann simon1hofmann added the enhancement New feature or request label Sep 25, 2024
Drewniok
Drewniok requested changes Sep 26, 2024
View reviewed changes
Copy link
Collaborator

@Drewniok Drewniok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's super cool! 😎

@simon1hofmann
Copy link
Collaborator Author

@Drewniok Thanks a lot for the review and feedback 🙏

github-actions[bot]
github-actions bot reviewed Sep 26, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

@simon1hofmann simon1hofmann requested a review from marcelwa October 7, 2024 07:51
marcelwa
marcelwa requested changes Oct 7, 2024
View reviewed changes
simon1hofmann and others added 4 commits October 7, 2024 16:16
@simon1hofmann @marcelwa
Apply suggestions from code review
344c138 
Co-authored-by: Marcel Walter <marcelwalter.mw@gmail.com>
Signed-off-by: simon1hofmann <119581649+simon1hofmann@users.noreply.github.com>
@pre-commit-ci
🎨 Incorporated pre-commit fixes
ea21dc4
@simon1hofmann
Merge branch 'main' into gold_multithreading
8e0e6d6
@actions-user
📝 Update pyfiction docstrings
96b281f 
Signed-off-by: GitHub Actions <actions@github.com>
github-actions[bot]
github-actions bot reviewed Oct 7, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

simon1hofmann and others added 2 commits October 7, 2024 17:03
@simon1hofmann
Feedback from Marcel
7da09c2
@actions-user
📝 Update pyfiction docstrings
949d7ce 
Signed-off-by: GitHub Actions <actions@github.com>
@simon1hofmann simon1hofmann requested a review from marcelwa October 7, 2024 15:08
github-actions[bot]
github-actions bot reviewed Oct 7, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

@marcelwa marcelwa merged commit 81b2a6c into cda-tum:main Oct 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@Drewniok Drewniok Drewniok requested changes

@marcelwa marcelwa marcelwa approved these changes

Assignees

@simon1hofmann simon1hofmann

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@simon1hofmann @marcelwa @Drewniok @actions-user