Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Timeout for post_layout_optimization and wiring_reduction #538

Merged
merged 24 commits into from
Oct 19, 2024

Conversation

simon1hofmann
Copy link
Collaborator

@simon1hofmann simon1hofmann commented Oct 10, 2024

Description

Added a timeout parameter to post_layout_optimization and wiring_reduction.
If a timeout is set for post_layout_optimization, the timeout for the call of wiring_reduction inside post_layout_optimization is handled automatically.

Additionally, post_layout_optimization was refactored for readability and a benchmark script was added.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have added a changelog entry.
  • I have created/adjusted the Python bindings for any new or updated functionality.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 99.76526% with 1 line in your changes missing coverage. Please review.

Project coverage is 98.16%. Comparing base (2e24360) to head (11e9edf).
Report is 86 commits behind head on main.

Files with missing lines Patch % Lines
...on/algorithms/physical_design/wiring_reduction.hpp 96.96% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #538      +/-   ##
==========================================
- Coverage   98.18%   98.16%   -0.02%     
==========================================
  Files         226      226              
  Lines       31765    31764       -1     
  Branches     1580     1585       +5     
==========================================
- Hits        31187    31182       -5     
- Misses        578      582       +4     
Files with missing lines Coverage Δ
...ithms/physical_design/post_layout_optimization.hpp 100.00% <100.00%> (ø)
...ithms/physical_design/post_layout_optimization.cpp 100.00% <100.00%> (ø)
...st/algorithms/physical_design/wiring_reduction.cpp 100.00% <100.00%> (ø)
...on/algorithms/physical_design/wiring_reduction.hpp 98.47% <96.96%> (-0.23%) ⬇️

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e24360...11e9edf. Read the comment docs.

@simon1hofmann simon1hofmann requested a review from hibenj October 10, 2024 15:20
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Collaborator

@marcelwa marcelwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a great addition, thanks a lot!

@simon1hofmann
Copy link
Collaborator Author

That's a great addition, thanks a lot!

Thanks a lot for the review, I took the opportunity to refactor the algorithm a little bit to make it more readable.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Collaborator

@marcelwa marcelwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally agree with the restructuring. It made me aware of a few things that can be improved here and there. Please have a look.

simon1hofmann and others added 2 commits October 16, 2024 12:51
Co-authored-by: Marcel Walter <marcelwalter.mw@gmail.com>
Signed-off-by: simon1hofmann <119581649+simon1hofmann@users.noreply.github.com>
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

simon1hofmann and others added 5 commits October 16, 2024 18:57
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: simon1hofmann <119581649+simon1hofmann@users.noreply.github.com>
Signed-off-by: GitHub Actions <actions@github.com>
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Collaborator

@marcelwa marcelwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks! 🙏

@marcelwa marcelwa merged commit aadf0ca into cda-tum:main Oct 19, 2024
61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants