-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Timeout for post_layout_optimization
and wiring_reduction
#538
Conversation
Signed-off-by: GitHub Actions <actions@github.com>
Signed-off-by: GitHub Actions <actions@github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
include/fiction/algorithms/physical_design/post_layout_optimization.hpp
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #538 +/- ##
==========================================
- Coverage 98.18% 98.16% -0.02%
==========================================
Files 226 226
Lines 31765 31764 -1
Branches 1580 1585 +5
==========================================
- Hits 31187 31182 -5
- Misses 578 582 +4
... and 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
clang-tidy review says "All clean, LGTM! 👍" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a great addition, thanks a lot!
include/fiction/algorithms/physical_design/post_layout_optimization.hpp
Outdated
Show resolved
Hide resolved
include/fiction/algorithms/physical_design/post_layout_optimization.hpp
Outdated
Show resolved
Hide resolved
include/fiction/algorithms/physical_design/wiring_reduction.hpp
Outdated
Show resolved
Hide resolved
Signed-off-by: GitHub Actions <actions@github.com>
Thanks a lot for the review, I took the opportunity to refactor the algorithm a little bit to make it more readable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
clang-tidy review says "All clean, LGTM! 👍" |
clang-tidy review says "All clean, LGTM! 👍" |
include/fiction/algorithms/physical_design/post_layout_optimization.hpp
Dismissed
Show dismissed
Hide dismissed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Totally agree with the restructuring. It made me aware of a few things that can be improved here and there. Please have a look.
include/fiction/algorithms/physical_design/wiring_reduction.hpp
Outdated
Show resolved
Hide resolved
include/fiction/algorithms/physical_design/post_layout_optimization.hpp
Outdated
Show resolved
Hide resolved
include/fiction/algorithms/physical_design/post_layout_optimization.hpp
Outdated
Show resolved
Hide resolved
include/fiction/algorithms/physical_design/post_layout_optimization.hpp
Outdated
Show resolved
Hide resolved
include/fiction/algorithms/physical_design/post_layout_optimization.hpp
Outdated
Show resolved
Hide resolved
include/fiction/algorithms/physical_design/post_layout_optimization.hpp
Outdated
Show resolved
Hide resolved
Co-authored-by: Marcel Walter <marcelwalter.mw@gmail.com> Signed-off-by: simon1hofmann <119581649+simon1hofmann@users.noreply.github.com>
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: GitHub Actions <actions@github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
include/fiction/algorithms/physical_design/post_layout_optimization.hpp
Outdated
Show resolved
Hide resolved
include/fiction/algorithms/physical_design/post_layout_optimization.hpp
Outdated
Show resolved
Hide resolved
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: simon1hofmann <119581649+simon1hofmann@users.noreply.github.com>
Signed-off-by: GitHub Actions <actions@github.com>
clang-tidy review says "All clean, LGTM! 👍" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks! 🙏
Description
Added a timeout parameter to
post_layout_optimization
andwiring_reduction
.If a timeout is set for
post_layout_optimization
, the timeout for the call ofwiring_reduction
insidepost_layout_optimization
is handled automatically.Additionally,
post_layout_optimization
was refactored for readability and a benchmark script was added.Checklist: