Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📥 Add Bestagon SiDB gate library #554

Merged
merged 2 commits into from
Oct 30, 2024
Merged

📥 Add Bestagon SiDB gate library #554

merged 2 commits into from
Oct 30, 2024

Conversation

Drewniok
Copy link
Collaborator

Description

Since a significant amount of the experiments use the Bestagon SiDB gate library, I propose to add it. This PR includes it with an additional tag for the canvas SiDBs (cell_type::LOGIC).

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have added a changelog entry.
  • I have created/adjusted the Python bindings for any new or updated functionality.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@Drewniok Drewniok added the enhancement New feature or request label Oct 30, 2024
@Drewniok Drewniok self-assigned this Oct 30, 2024
@Drewniok Drewniok requested a review from marcelwa October 30, 2024 18:22
marcelwa
marcelwa approved these changes Oct 30, 2024
View reviewed changes
Copy link
Collaborator

@marcelwa marcelwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a great idea, thank you very much 🙏 would you mind adding the SiQAD gates as well in a seperate PR?

@Drewniok Drewniok changed the title 📥 Add _Bestagon_ SiDB gate library 📥 Add Bestagon SiDB gate library Oct 30, 2024
@Drewniok
Copy link
Collaborator Author

Good point! I will!

@marcelwa marcelwa merged commit dbe3b43 into cda-tum:main Oct 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcelwa marcelwa marcelwa approved these changes

Assignees

@Drewniok Drewniok

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Drewniok @marcelwa