Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐳 Improved the Docker workflow #558

Merged
merged 17 commits into from
Nov 5, 2024
Merged

🐳 Improved the Docker workflow #558

merged 17 commits into from
Nov 5, 2024

Conversation

marcelwa
Copy link
Collaborator

@marcelwa marcelwa commented Oct 31, 2024 •
edited
Loading

Description

This PR updates the Docker workflow. Most notably, the following changes are made:

  • .dockerignore:
    • added new file types and folders, yielding smaller image sizes
    • fixed paths, applying filter rules to sub-directories, yielding smaller image sizes
  • Dockerfile:
    • set Ubuntu version to a specific LTS release
    • added labels with meta info
    • enforced a clean-up after build, yielding smaller image sizes
    • initiated all installs and builds as a non-root user
  • Docker GitHub CI:
    • added the ability to publish images to DockerHub

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have added a changelog entry.
  • I have created/adjusted the Python bindings for any new or updated functionality.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@marcelwa
🔧 Added file types to .dockerignore and fixed paths to include sub-…
745e9a9 
…folders
@marcelwa
🐳 Updated Dockerfile:
ab33884 
- fix Ubuntu version to a specific LTS release
- added labels with meta info
- clean up after build
- run installs and builds as non-root
@marcelwa
👷 Extended the Docker CI with the ability to push images to DockerHub…
b62d532 
…. This ability is activated by default in this commit for testing but will be limited to published releases once it is verified that everything works as intended
@marcelwa marcelwa added github_actions Pull requests that update GitHub Actions code docker Pull requests that relate to Docker labels Oct 31, 2024
@marcelwa marcelwa self-assigned this Oct 31, 2024
marcelwa added 14 commits October 31, 2024 16:25
@marcelwa
👷 Extended the Docker CI with the ability to push images to GitHub Pa…
7df683b 
…ckages as well. This ability is activated by default in this commit for testing but will be limited to published releases once it is verified that everything works as intended
@marcelwa
💚 Added a fallback tag in case the release tag name is not available
5bfb8fc
@marcelwa
💚 Split artifact attestation into two steps, one for GitHub Packages …
6a856bc 
…and one for DockerHub
@marcelwa
💚 Use environment variable instead of secret for the DockerHub userna…
bd7e45c 
…me as it is not a secret
@marcelwa
👷 Push the README file as the project description to DockerHub
862060a
@marcelwa
💚 Remove tag from Docker subject name when generating artifact attest…
f307d6e 
…ation
@marcelwa
💚 Try README assignment via secret username
f703bf2
@marcelwa
🔐 Adjusted secrets
30c8582 
Signed-off-by: Marcel Walter <marcel.walter@tum.de>
@marcelwa
💚 Removed tag from ghcr.io subject name
1667ec9 
Signed-off-by: Marcel Walter <marcel.walter@tum.de>
@marcelwa
👷 Added a verification step to check if the image exists at GHCR
dee43b8
@marcelwa
💚 Artifact attestation is enabled for GHCR out-of-the-box
2f5f6d8
@marcelwa
📝 Use absolute link for light MNT logo
387120e
@marcelwa
👷 Replaced env with secrets
a8d6c35 
Signed-off-by: Marcel Walter <marcel.walter@tum.de>
@marcelwa
👷 Re-enabled the safe guards to publish new images only for newly rel…
0d34664 
…eased versions

Signed-off-by: Marcel Walter <marcel.walter@tum.de>
@marcelwa marcelwa merged commit a9c3093 into main Nov 5, 2024
3 checks passed
@marcelwa marcelwa deleted the docker-update branch November 5, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@marcelwa marcelwa

Labels
docker Pull requests that relate to Docker github_actions Pull requests that update GitHub Actions code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@marcelwa