Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐍 Expose layout.get_name #575

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Conversation

simon1hofmann
Copy link
Collaborator

@simon1hofmann simon1hofmann commented Nov 13, 2024

Description

Exposed layout.get_name(signal) to pyfiction.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have added a changelog entry.
  • I have created/adjusted the Python bindings for any new or updated functionality.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@simon1hofmann simon1hofmann self-assigned this Nov 13, 2024
@simon1hofmann simon1hofmann added the python Pull requests that update Python code label Nov 13, 2024
@simon1hofmann simon1hofmann changed the title 🐍 Exposed layout.get_name 🐍 Expose layout.get_name Nov 13, 2024
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.22%. Comparing base (cef8547) to head (6984668).
Report is 137 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #575   +/-   ##
=======================================
  Coverage   98.21%   98.22%           
=======================================
  Files         228      228           
  Lines       35746    35756   +10     
  Branches     1692     1688    -4     
=======================================
+ Hits        35109    35122   +13     
+ Misses        637      634    -3     

see 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d80fbe...6984668. Read the comment docs.

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@marcelwa marcelwa merged commit 2eec2ad into cda-tum:main Nov 13, 2024
65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants