Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Enforce runtime evaluation of dynamic formatting strings to fix consteval contexts #585

Merged
merged 2 commits into from
Nov 18, 2024
+59 −23
Merged

🐛 Enforce runtime evaluation of dynamic formatting strings to fix consteval contexts #585

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1cccfc9
:bug: Enforce runtime evaluation of dynamic formatting strings to fix…
marcelwa Nov 17, 2024
10b0924
:art: Address `clang-tidy` warning
marcelwa Nov 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Loading
Loading status checks…
🎨 Address clang-tidy warning
@marcelwa
marcelwa committed Nov 17, 2024
commit 10b092490e4a813a768979ef584cb5ea4009764b
56 changes: 46 additions & 10 deletions include/fiction/technology/cell_ports.hpp
View file
Original file line number Diff line number Diff line change
@@ -299,17 +299,53 @@ struct formatter<fiction::port_direction>
template <typename FormatContext>
auto format(const fiction::port_direction& p, FormatContext& ctx) const
{
const auto dir = p.dir == fiction::port_direction::NORTH ? "N" :
p.dir == fiction::port_direction::NORTH_EAST ? "NE" :
p.dir == fiction::port_direction::EAST ? "E" :
p.dir == fiction::port_direction::SOUTH_EAST ? "SE" :
p.dir == fiction::port_direction::SOUTH ? "S" :
p.dir == fiction::port_direction::SOUTH_WEST ? "SW" :
p.dir == fiction::port_direction::WEST ? "W" :
p.dir == fiction::port_direction::NORTH_WEST ? "NW" :
"?";
const auto* dir = "?";

return format_to(ctx.out(), runtime(dir));
switch (p.dir)
{
case fiction::port_direction::NORTH:
{
dir = "N";
break;
}
case fiction::port_direction::NORTH_EAST:
{
dir = "NE";
break;
}
case fiction::port_direction::EAST:
{
dir = "E";
break;
}
case fiction::port_direction::SOUTH_EAST:
{
dir = "SE";
break;
}
case fiction::port_direction::SOUTH:
{
dir = "S";
break;
}
case fiction::port_direction::SOUTH_WEST:
{
dir = "SW";
break;
}
case fiction::port_direction::WEST:
{
dir = "W";
break;
}
case fiction::port_direction::NORTH_WEST:
{
dir = "NW";
break;
}
}

return format_to(ctx.out(), dir);
}
};
// make port_list compatible with fmt::format