🐛 Fixed design_sidb_gates function for skeletons with east-facing I/O pins.
#594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: GitHub Actions <actions@github.com>
…_east' into bug_fix_quickcell_wire_direction_east
Drewniok
changed the title
6 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #594 +/- ##
=======================================
Coverage 98.11% 98.12%
=======================================
Files 232 232
Lines 35370 35410 +40
Branches 1707 1691 -16
=======================================
+ Hits 34704 34746 +42
+ Misses 666 664 -2
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
|
clang-tidy review says "All clean, LGTM! 👍" |
Drewniok
changed the title
design_sidb_gates function for skeletons with east-facing I/O pins.
marcelwa
requested changes
Nov 26, 2024
include/fiction/algorithms/physical_design/design_sidb_gates.hpp
Outdated
Show resolved
Hide resolved
|
clang-tidy review says "All clean, LGTM! 👍" |
marcelwa
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the following bug in the
design_sidb_gatesfunction: When using a gate skeleton with wires facing east, the gate design would not work.The error occurred during the second pruning step when using QuickCell for designing SiDB gates. During this step, the feasibility of the physical validity is checked by toggling through different input patterns and adjusting the charge distribution of the I/O pins accordingly. However, the logic failed for I/O pins facing east because this specific case was not accounted for in the if statement. This is now fixed.
Checklist: