-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Added rectangular skeletons (16.896 nm x 16.896 nm) with design script. #600
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #600 +/- ##
==========================================
- Coverage 98.14% 98.12% -0.02%
==========================================
Files 232 232
Lines 35410 35410
Branches 1690 1692 +2
==========================================
- Hits 34753 34746 -7
- Misses 656 663 +7
Partials 1 1 see 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
clang-tidy review says "All clean, LGTM! 👍" |
clang-tidy review says "All clean, LGTM! 👍" |
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: GitHub Actions <actions@github.com>
clang-tidy review says "All clean, LGTM! 👍" |
@marcelwa, can you tell me if anything else needs to be done before this is merged? |
Did you not want to integrate your new library as an |
I would rather do this in a separate PR. The reason for this is that this PR is more the basis for further exploration in this direction. If we decide to go in that direction, we can gladly integrate into the |
That's alright. Makes sense to me. |
Description
This PR introduces rectangular skeletons measuring
16.896 nm x 16.896 nm
for designing gate implementations. Moreover, it adds a script to design a corresponding gate library.Some results:
CX (input pattern: 01 left/top):
AND (input pattern: 01 left/top):
Fan-out (input pattern: 1 at the top):
Checklist: