Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Added rectangular skeletons (16.896 nm x 16.896 nm) with design script. #600

Merged
merged 12 commits into from
Dec 17, 2024

Conversation

Drewniok
Copy link
Collaborator

@Drewniok Drewniok commented Dec 1, 2024

Description

This PR introduces rectangular skeletons measuring 16.896 nm x 16.896 nm for designing gate implementations. Moreover, it adds a script to design a corresponding gate library.

Some results:

CX (input pattern: 01 left/top):

AND (input pattern: 01 left/top):

Fan-out (input pattern: 1 at the top):

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have added a changelog entry.
  • I have created/adjusted the Python bindings for any new or updated functionality.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@Drewniok Drewniok added the enhancement New feature or request label Dec 1, 2024
@Drewniok Drewniok self-assigned this Dec 1, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Copy link

codecov bot commented Dec 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.12%. Comparing base (f1cc971) to head (83f0079).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #600      +/-   ##
==========================================
- Coverage   98.14%   98.12%   -0.02%     
==========================================
  Files         232      232              
  Lines       35410    35410              
  Branches     1690     1692       +2     
==========================================
- Hits        34753    34746       -7     
- Misses        656      663       +7     
  Partials        1        1              

see 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 176d3d0...83f0079. Read the comment docs.

@Drewniok Drewniok requested a review from marcelwa December 2, 2024 07:55
Copy link
Contributor

github-actions bot commented Dec 4, 2024

clang-tidy review says "All clean, LGTM! 👍"

@Drewniok Drewniok requested a review from marcelwa December 7, 2024 17:32
Copy link
Contributor

github-actions bot commented Dec 7, 2024

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Contributor

github-actions bot commented Dec 8, 2024

clang-tidy review says "All clean, LGTM! 👍"

Drewniok and others added 2 commits December 15, 2024 17:04
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@Drewniok
Copy link
Collaborator Author

@marcelwa, can you tell me if anything else needs to be done before this is merged?

@marcelwa
Copy link
Collaborator

@marcelwa, can you tell me if anything else needs to be done before this is merged?

Did you not want to integrate your new library as an fcn_gate_library subclass to map to when using apply_gate_library?

@Drewniok
Copy link
Collaborator Author

@marcelwa, can you tell me if anything else needs to be done before this is merged?

Did you not want to integrate your new library as an fcn_gate_library subclass to map to when using apply_gate_library?

I would rather do this in a separate PR. The reason for this is that this PR is more the basis for further exploration in this direction. If we decide to go in that direction, we can gladly integrate into the fcn_gate_library. But for now, I would rather use it to experiment with single-gate implementations.

@marcelwa
Copy link
Collaborator

@marcelwa, can you tell me if anything else needs to be done before this is merged?

Did you not want to integrate your new library as an fcn_gate_library subclass to map to when using apply_gate_library?

I would rather do this in a separate PR. The reason for this is that this PR is more the basis for further exploration in this direction. If we decide to go in that direction, we can gladly integrate into the fcn_gate_library. But for now, I would rather use it to experiment with single-gate implementations.

That's alright. Makes sense to me.

@Drewniok Drewniok merged commit df6b61e into cda-tum:main Dec 17, 2024
2 checks passed
@Drewniok Drewniok deleted the rectangular_skeletons branch December 17, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants