Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 Set up ruff and mypy, and extend the pre-commit configuration #603

Merged
merged 7 commits into from
Dec 4, 2024

Conversation

marcelwa
Copy link
Collaborator

@marcelwa marcelwa commented Dec 3, 2024

Description

This PR sets up ruff as a Python linter, mypy for static Python type checking, and extends the pre-commit configuration by check-jsonschema, validate-pyproject-schema-store, nb-clean, prettier, ruff, and mypy.

Many ruff checks are enabled (with some still requiring some work to comply fully).

Additionally, all corresponding linter warnings are also fixed in this PR.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have added a changelog entry.
  • I have created/adjusted the Python bindings for any new or updated functionality.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@marcelwa marcelwa self-assigned this Dec 3, 2024
@marcelwa marcelwa added the tooling Introduced or configured tools label Dec 3, 2024
Copy link
Contributor

github-actions bot commented Dec 3, 2024

clang-tidy review says "All clean, LGTM! 👍"

Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.12%. Comparing base (d5c1b8a) to head (18c5e45).
Report is 118 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #603   +/-   ##
=======================================
  Coverage   98.12%   98.12%           
=======================================
  Files         232      232           
  Lines       35410    35410           
  Branches     1691     1691           
=======================================
  Hits        34747    34747           
+ Misses        662      661    -1     
- Partials        1        2    +1     

see 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af4650b...18c5e45. Read the comment docs.

@marcelwa marcelwa merged commit a30097d into main Dec 4, 2024
43 checks passed
@marcelwa marcelwa deleted the ruff branch December 4, 2024 17:15
Copy link
Contributor

github-actions bot commented Dec 4, 2024

clang-tidy review says "All clean, LGTM! 👍"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tooling Introduced or configured tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant