Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Added the SRS clocking scheme #641

Merged
merged 10 commits into from
Jan 23, 2025

Conversation

simon1hofmann
Copy link
Collaborator

@simon1hofmann simon1hofmann commented Jan 20, 2025

Description

This PR adds the SRS clocking scheme proposed in this work.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have added a changelog entry.
  • I have created/adjusted the Python bindings for any new or updated functionality.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Copy link

codecov bot commented Jan 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@1cdb4b9). Learn more about missing BASE report.
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #641   +/-   ##
=======================================
  Coverage        ?   98.13%           
=======================================
  Files           ?      235           
  Lines           ?    36137           
  Branches        ?     1755           
=======================================
  Hits            ?    35464           
  Misses          ?      673           
  Partials        ?        0           
Files with missing lines Coverage Δ
include/fiction/layouts/clocking_scheme.hpp 95.60% <100.00%> (ø)
test/algorithms/physical_design/exact.cpp 98.71% <100.00%> (ø)
test/layouts/clocking_scheme.cpp 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cdb4b9...e9ec90f. Read the comment docs.

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@simon1hofmann simon1hofmann self-assigned this Jan 22, 2025
@simon1hofmann simon1hofmann added the enhancement New feature or request label Jan 22, 2025
Copy link
Collaborator

@marcelwa marcelwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, many thanks! 🙏

@marcelwa marcelwa enabled auto-merge (squash) January 23, 2025 02:08
@marcelwa marcelwa merged commit 025679e into cda-tum:main Jan 23, 2025
45 checks passed
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants