Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚗️ Updated QuickCell experiment #643

Merged
merged 18 commits into from
Jan 24, 2025

Conversation

Drewniok
Copy link
Collaborator

Description

This PR updates the QuickCell experiment to address outdated pathnames.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have added a changelog entry.
  • I have created/adjusted the Python bindings for any new or updated functionality.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@Drewniok Drewniok added the bug Something isn't working label Jan 23, 2025
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.12%. Comparing base (025679e) to head (77e09cb).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #643      +/-   ##
==========================================
- Coverage   98.13%   98.12%   -0.01%     
==========================================
  Files         235      235              
  Lines       36137    36137              
  Branches     1754     1754              
==========================================
- Hits        35464    35461       -3     
- Misses        672      675       +3     
  Partials        1        1              

see 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 025679e...77e09cb. Read the comment docs.

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@Drewniok Drewniok requested a review from marcelwa January 23, 2025 14:01
Copy link
Collaborator

@marcelwa marcelwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just a minor detail here.

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@Drewniok Drewniok requested a review from marcelwa January 24, 2025 05:59
@Drewniok Drewniok merged commit 1332d8b into cda-tum:main Jan 24, 2025
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants