-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Fixed layout resizing in apply_gate_library
#653
🐛 Fixed layout resizing in apply_gate_library
#653
Conversation
Signed-off-by: GitHub Actions <actions@github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #653 +/- ##
==========================================
- Coverage 98.43% 98.40% -0.03%
==========================================
Files 252 252
Lines 40846 40856 +10
Branches 1863 1863
==========================================
Hits 40206 40206
- Misses 640 650 +10
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks for the quick fix! Some minor comments below 🙂
include/fiction/algorithms/physical_design/apply_gate_library.hpp
Outdated
Show resolved
Hide resolved
Signed-off-by: GitHub Actions <actions@github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
include/fiction/algorithms/physical_design/apply_gate_library.hpp
Outdated
Show resolved
Hide resolved
include/fiction/algorithms/physical_design/apply_gate_library.hpp
Outdated
Show resolved
Hide resolved
It looks like Clang-Tidy is not too happy about |
clang-tidy review says "All clean, LGTM! 👍" |
Description
When applying a gate library to a hexagonal gate-level layout, the resulting cell-level layout would not have the right sizing.
The implemented fix now supports tiling geometries in which all even rows/columns are aligned and all odd rows/columns are aligned.
Checklist: