Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fixed layout resizing in apply_gate_library #653

Merged
merged 10 commits into from
Jan 31, 2025

Conversation

wlambooy
Copy link
Collaborator

Description

When applying a gate library to a hexagonal gate-level layout, the resulting cell-level layout would not have the right sizing.

The implemented fix now supports tiling geometries in which all even rows/columns are aligned and all odd rows/columns are aligned.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have added a changelog entry.
  • I have created/adjusted the Python bindings for any new or updated functionality.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

wlambooy and others added 2 commits January 30, 2025 15:03
@wlambooy wlambooy requested a review from marcelwa January 30, 2025 14:16
@wlambooy wlambooy added the bug Something isn't working label Jan 30, 2025
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.40%. Comparing base (f2867d1) to head (43e2da8).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #653      +/-   ##
==========================================
- Coverage   98.43%   98.40%   -0.03%     
==========================================
  Files         252      252              
  Lines       40846    40856      +10     
  Branches     1863     1863              
==========================================
  Hits        40206    40206              
- Misses        640      650      +10     
Files with missing lines Coverage Δ
.../algorithms/physical_design/apply_gate_library.hpp 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2867d1...43e2da8. Read the comment docs.

Copy link
Collaborator

@marcelwa marcelwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for the quick fix! Some minor comments below 🙂

@wlambooy wlambooy requested a review from marcelwa January 30, 2025 17:11
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

@wlambooy
Copy link
Collaborator Author

It looks like Clang-Tidy is not too happy about using with something that is not a type

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@marcelwa marcelwa merged commit 08c6914 into cda-tum:main Jan 31, 2025
49 checks passed
@wlambooy wlambooy deleted the fix-layout-resizing-from-hexagonal branch January 31, 2025 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants