Issue15 matthew mizielinski CVs and tables fixes #16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes I've made to get this past CMOR:
table_id
in every MIP tablemip_era
from "CMIP6" to "SNAPSI" everywhere (CMOR will look for tables & CVs named "CMIP6_*" otherwise)activity_id
andparent_experiment_id
fields need to be listsallowed_model_components
with a default ofAOGCM
andAER
. Therequired_model_components
can also be used if there are requirements on experiments.SNAPSI_coordinate.json
was invalid as the entry for the plev137 pressure level set was not closed properly. Note that this entry may be missing a number of required fields.sdepth1
dimension which is used inmrsos
in the6hrPt
table.Conventions
field in the grids definition table to be consistent with else where.Other changes:
data_specs_version
to0.9.3
and ensured that this format is allowed by the CVstable_date
consistently to today's datetracking_id
pattern in CVs set toSNAPSI/.*
-- CMOR doesn't like absent prefixes and it needs to include the.*
pattern.A number of the above should be reviewed and possibly altered depending on your purposes. In particular the use of
allowed_model_components
/required_model_components
in the experiment definitions, theplev137
pressure level entry and the license pattern should be considered further.P.S. The edits to the CVs were made a little crudely. Might be worth pushing through the JSON library to get a cleaner structure (
python -m json.tool <input file>
would clean this up).