Refactor Protobufs code #561
Merged
+593
−575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shaobo He <shaobohe@amazon.com>
Signed-off-by: Shaobo He <shaobohe@amazon.com>
cdisselkoen
approved these changes
Mar 3, 2025
john-h-kastner-aws
approved these changes
Mar 3, 2025
There was a problem hiding this comment.
Looks better to me.
I will say that I don't personally like indenting the => arrow on matches to the same column. It looks nicer when reading the code, but it tends to require making changes to unrelated lines of code when adding a new match case or changing a pattern, making some diffs harder to understand and potentially creating merge conflicts. Wondering what other people think about this.
Co-authored-by: Craig Disselkoen <cdiss@amazon.com>
…-refactor Signed-off-by: Shaobo He <shaobohe@amazon.com>
chaluli
reviewed
Mar 17, 2025
Signed-off-by: Shaobo He <shaobohe@amazon.com>
chaluli
approved these changes
Mar 17, 2025
emina
reviewed
Mar 17, 2025
| | [], _ => y.slotEnv | ||
| | _, [] => x.slotEnv | ||
| | xkvs, ykvs => Data.Map.make $ xkvs ++ ykvs | ||
| | [], _ => y.slotEnv |
There was a problem hiding this comment.
The => aligned cases are so nice to look at :D
| pure ignore | ||
| | 1 => | ||
| let x : Proto.Map String (Qualified ProtoType) ← Field.guardedParse t | ||
| pureMergeFn (RecordType.mergeAttrs · x.toList) |
There was a problem hiding this comment.
Lots of boilerplate eliminated with pureMergFn!
| @@ -27,6 +27,8 @@ namespace Proto | |||
|
|
|||
| def MergeFn (α : Type) : Type := (α → BParsec α) | |||
|
|
|||
| def pureMergeFn (f : α → α) : BParsec (MergeFn α) := pure (f <$> pure ·) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
There are two kinds of changes in this PR.
pureMergeFnsuch thatpure (pure $ f)becomespureMergeFn f.matchexpressions.