Term description of date fields have timezone

[kurtrwall]

When a single datetime/time is saved, it is saved in a taxonomy as a term. In this term, the description is empty. This uses the empty description to save the timezone of the field. This is useful for the event ics file generation. Without it, the event start/end times are set in the UTC timezone.

Test

Save an unrepeated time or datetime field and look at the api output. If the term has a description that matches the timezone selected for the field, then mission accomplished.

@jimmynotjim @Scotchester

[Scotchester]

Isn't there a way to store the timezone as part of the datetime or time field itself?

[kurtrwall]

There is, but there are a couple problems with it. For instance, when a date is saved, the information is in a tag below the input fields. When saving the post again there isn't any of the data in the $_POST dictionary is it gets wiped out each time. And on top of that, if we just put the data back in the input fields, the post would resave data that we already saved or, more importantly, if it were a field that allowed multiple dates then we couldn't know which date data to put back into the input fields.

[kurtrwall]

The real solution is to move the date fields away from saving into a taxonomy. That's a bigger effort.

[Scotchester]

How is the timezone set on the front end?

[kurtrwall]

In each of the time/datetime fields, there is an input for timezone that must be set for each field.

[Scotchester]

Which already existed? It just wasn't being stored in this manner, before?

[kurtrwall]

It was added when datetime and time fields were created.

[kurtrwall]

@dpford @Scotchester @jimmynotjim this should get in before we start really putting content into Wordpress for events, as the event ics file relies on this to work correctly.

[jimmynotjim]

Tested locally and working. Thanks for making the formatting the same across timestamps. 👍

[Scotchester]

@jimmynotjim Did you run the tests? That was the only thing I wanted to do before diving a thumbs up.

[dpford]

+1 for working locally, have to install phpunit to run tests

[jimmynotjim]

yep, just ran the tests with Kurt's help getting phpunit working.

[jimmynotjim]

and kurt is the bomb

(downside to screenhero is kurt patting himself on the shoulder)

[kurtrwall]

Merging since it has enough thumbs. Up that is.